feat: generate wheels package with underscores instead of dashes#907
feat: generate wheels package with underscores instead of dashes#907rborsaru-ansys wants to merge 23 commits intomainfrom
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
jorgepiloto
left a comment
There was a problem hiding this comment.
Just left one suggestion for this, @rborsaru-ansys. Knowing that the build library accepts now a working directory, maybe we can revisit the tests job in this file.
|
Hi @rborsaru-ansys, I don't know why this PR is open but if you want to test a change to any action in this repo, could you simply update your CICD workflow and reference this branch, e.g. ansys/actions@v10 -> ansys/actions@fix/unify-artifacts-file-names, instead of opening a PR ? |
|
Hi @jorgepiloto and @SMoraisAnsys , Thank you. |
jorgepiloto
left a comment
There was a problem hiding this comment.
Awesome, @rborsaru-ansys. Thanks for fixing this.
SMoraisAnsys
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @rborsaru-ansys
RobPasMue
left a comment
There was a problem hiding this comment.
Raised my concerns in #681 - but this implementation is great @rborsaru-ansys ! Thanks a lot!
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Requesting changes to avoid this PR to be merged as long as the discussion in #681 is not over.
jorgepiloto
left a comment
There was a problem hiding this comment.
Almost there, just left one minor comment.
| python-version: ${{ matrix.python }} | ||
| working-directory: .ci/ansys-actions | ||
|
|
||
| package-library: |
There was a problem hiding this comment.
Maybe, we could reuse this in other parts of the code before uploading the dist to the PyPI Test. We can try to do this in a separate pull-request.
|
I have fixed the build-library action code to properly use the working-directory. Now my job only fails because of the final tests and that is because of the name of the library. |
|
Closing this and opening a fresh PR. |
Initial commit for this branch